Skip to content

Support other OS on tests #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Support other OS on tests #1715

merged 1 commit into from
Jul 17, 2025

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented May 20, 2025

Summary

I think it would make collaborations easier if other OS(line feed issue) were supported in testing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn
Copy link
Collaborator

mfn commented May 20, 2025

Where did you see the issue with the tests (guess not on Linux or Windows, as those tests are green)?

@erikn69
Copy link
Contributor Author

erikn69 commented May 20, 2025

windows has \r\n when not core.autocrlf false/core.eol lf

- name: Set git to use LF
if: ${{ matrix.os == 'windows-2019' }}
run: |
git config --global core.autocrlf false
git config --global core.eol lf

There are also other fixes

@barryvdh barryvdh merged commit 6d96f0b into barryvdh:master Jul 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants